Repository navigation
fix(gh-aw): remove mutable generated router - #2148
Merged
Merged
Conversation
Contributor
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 3 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | All 1 Copilot thread(s) resolved |
| ✅ | CI passing | All checks passing |
Files Changed (20 files, +337 −131)
| File | +/− |
|---|---|
.changeset/remove-mutable-gh-aw-router.md |
+6 −0 |
.github/agents.md |
+13 −0 |
.github/skills/agentic-workflows/SKILL.md |
+0 −98 |
.github/workflows/squad-ci.yml |
+1 −0 |
.squad-templates/skills/gh-aw-enlistment/SKILL.md |
+26 −3 |
README.md |
+6 −1 |
docs/src/content/docs/guide/gh-aw.md |
+30 −7 |
packages/squad-cli/templates/skills/gh-aw-enlistment/SKILL.md |
+26 −3 |
packages/squad-sdk/templates/skills/gh-aw-enlistment/SKILL.md |
+26 −3 |
scripts/gh-aw-hosted-e2e.mjs |
+1 −0 |
templates/skills/gh-aw-enlistment/SKILL.md |
+26 −3 |
test/gh-aw-enlistment-skill.test.ts |
+28 −0 |
test/gh-aw-hosted-e2e.test.ts |
+3 −1 |
test/gh-aw-install-staging.test.ts |
+69 −1 |
test/gh-aw-quality.test.ts |
+20 −0 |
workflows/package/squad-bootstrap.md |
+1 −1 |
workflows/shared/squad-install-verifier.mjs |
+23 −1 |
workflows/skills/gh-aw-enlistment/SKILL.md |
+26 −3 |
workflows/squad-bootstrap.md |
+1 −1 |
workflows/squad-workflows.manifest.json |
+5 −5 |
Total: +337 −131
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
🟠 Impact Analysis — PR #2148Risk tier: 🟠 HIGH 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (3 files)
docs (1 file)
root (8 files)
scripts (1 file)
squad-cli (1 file)
squad-sdk (1 file)
templates (1 file)
tests (4 files)
This report is generated automatically for every PR. See #733 for details. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The verifier, staged-index gate, synchronized artifacts, documentation, and focused regressions consistently enforce the intended removal.
Review effort: Balanced
Findings: None
What changed in this PR
Removes gh-aw’s mutable generated router while preserving Squad-owned enlistment and maintenance resources.
Changes:
- Rejects the router in installed and staged trees.
- Removes it from install workflows and documentation.
- Adds regressions and synchronizes generated artifacts/templates.
| File | Description |
|---|---|
workflows/squad-workflows.manifest.json |
Refreshes integrity digests. |
workflows/squad-bootstrap.md |
Updates verifier digest. |
workflows/package/squad-bootstrap.md |
Updates generated verifier digest. |
workflows/shared/squad-install-verifier.mjs |
Rejects router in working and staged trees. |
workflows/skills/gh-aw-enlistment/SKILL.md |
Documents removal and staged-deletion rules. |
.squad-templates/skills/gh-aw-enlistment/SKILL.md |
Updates canonical skill template. |
templates/skills/gh-aw-enlistment/SKILL.md |
Synchronizes root template. |
packages/squad-cli/templates/skills/gh-aw-enlistment/SKILL.md |
Synchronizes CLI template. |
packages/squad-sdk/templates/skills/gh-aw-enlistment/SKILL.md |
Synchronizes SDK template. |
.github/skills/agentic-workflows/SKILL.md |
Deletes the mutable router. |
.github/workflows/squad-ci.yml |
Removes router in clean-consumer CI. |
scripts/gh-aw-hosted-e2e.mjs |
Removes router during hosted installation. |
test/gh-aw-install-staging.test.ts |
Tests install and staged-tree rejection. |
test/gh-aw-hosted-e2e.test.ts |
Checks hosted removal ordering. |
test/gh-aw-enlistment-skill.test.ts |
Tests skill and guide instructions. |
test/gh-aw-quality.test.ts |
Checks router absence and maintenance retention. |
README.md |
Updates installation guidance. |
.github/agents.md |
Explains intentional router removal. |
docs/src/content/docs/guide/gh-aw.md |
Updates install, upgrade, and verification guidance. |
.changeset/remove-mutable-gh-aw-router.md |
Records CLI and SDK patch changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Reject gh-aw's unowned mutable agentic-workflows skill in final and staged installation verification while preserving the exact Squad enlistment skill. Finding: octodemo/zava-social-queue-worker-20261002092250#1 comment 4164580830 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document and enforce that repository routing uses the owned agentic-workflows specialist, designer, and reliability skill without the mutable gh-aw router. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
bradygaster
force-pushed
the
bradygaster-remove-mutable-gh-aw-scaffold
branch
from
October 2, 2026 12:58
68b0a47 to
ba2e2e7
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes gh-aw v0.89.22's generated
.github/skills/agentic-workflows/SKILL.mdand updates Squad enlistment so consumer installs delete and reject that unowned mutable router while preserving the exact Squad-ownedgh-aw-enlistmentskill.Why
A clean hosted fixture found that the generated router loads mutable prompt files from the current
github/gh-awrepository, so future workflow-authoring behavior was not bound to the pinned Squad SHA or compiler version. Source finding:octodemo/zava-social-queue-worker-20261002092250#1, review comment4164580830.How
agentic-workflowsrouter; retainagentics-maintenance.ymlbecause it provides configured safe-output expiration maintenance.Repository independence conclusion: no repository routing or authoring contract depends on the deleted router.
.squad/routing.mdassigns gh-aw work directly toagentic-workflows-dev; the trackedagentic-workflow-designerandgh-aw-reliabilityskills provide owned design and validation surfaces. Retaining a rewritten or pinned generic router would make Squad own a fork of the upstream gh-aw prompt router and corpus, creating vendor drift; removal is the narrower and safer boundary.PR Readiness Checklist
Branch & Commit
dev(notmain)devbasegit diff --cached --stat)Build & Test
npm run build -w packages/squad-sdkpassesnpm run build -w packages/squad-clipassestestcheck passes on exact headnpm run lintpassesnpm run lint:eslintpassesnode node_modules/vitest/vitest.mjs run test/gh-aw-*.test.tspasses: 28 files, 1,956 testsnode workflows/shared/squad-install-verifier.mjs --check-sourcepassesagentics-maintenance.ymlremains68b0a473fdd47f8f559cf80d44ffbcd30fa5a226: approval recommended, findings noneChangeset
.changeset/remove-mutable-gh-aw-router.mdCHANGELOG.mdentry — N/Askip-changeloglabel — N/ADocs
Exports
Breaking Changes
None.
Waivers
None.